Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pixel GPU client: fix siPixelPhase1RawDataErrorComparator collections post-alpaka migration #44933

Merged
merged 1 commit into from
May 10, 2024
Merged

Pixel GPU client: fix siPixelPhase1RawDataErrorComparator collections post-alpaka migration #44933

merged 1 commit into from
May 10, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 8, 2024 •
edited
Loading

PR description:

Title says it all, provide right collections to be monitored by the DQM/Integration/python/clients/pixelgpu_dqm_sourceclient-live_cfg.py after the pixel local reconstruction at HLT migration to alpaka (cf https://its.cern.ch/jira/browse/CMSHLT-3125 and https://its.cern.ch/jira/browse/CMSHLT-3132).
Noticed that in recent runs all plots are empty (see e.g. link) and confirmed by looking at the dqm-square logs e.g.:

%MSG-e SiPixelPhase1RawDataErrorComparator:   SiPixelPhase1RawDataErrorComparator:siPixelPhase1RawDataErrorComparator  08-May-2024 18:58:22 CEST Run: 380509 Event: 5010
reference (cpu) SiPixelRawDataErrors collection (hltSiPixelDigisLegacy) not found; 
the comparison will not run.
%MSG

PR validation:

None, the streamer files used for input tests need to be updated.
Validation will rely on a DQM replay.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, to be backported to 14.0.X for data-taking purposes

@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone May 8, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024 •
edited
Loading

cms-bot internal usage

@mmusich mmusich mentioned this pull request May 8, 2024
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44933/40208

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • DQM/Integration (dqm)

@rvenditti, @cmsbuild, @tjavaid, @antoniovagnerini, @syuvivida, @nothingface0 can you please review it and eventually sign? Thanks.
@francescobrivio, @threus, @batinkov this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented May 8, 2024

type trk, bug-fix

@mmusich
Copy link
Contributor Author

mmusich commented May 8, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44933/40209

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024

Pull request #44933 was updated. @nothingface0, @tjavaid, @antoniovagnerini, @syuvivida, @rvenditti, @cmsbuild can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented May 8, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-731c53/39312/summary.html
COMMIT: b4a1625
CMSSW: CMSSW_14_1_X_2024-05-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44933/39312/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3332476
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3332447
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented May 9, 2024

urgent

@cmsbuild cmsbuild added the urgent label May 9, 2024
@antoniovilela
Copy link
Contributor

+orp

@antoniovilela
Copy link
Contributor

ping @cms-sw/dqm-l2

@tjavaid
Copy link

tjavaid commented May 10, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit ef1f577 into cms-sw:master May 10, 2024
11 checks passed
@mmusich mmusich deleted the fix_pixel_gpu_client branch May 10, 2024 05:38
This was referenced May 10, 2024
Merged
Merged
@mmusich mmusich mentioned this pull request Jun 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix code-checks-approved dqm-approved fully-signed orp-approved tests-approved trk urgent
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.
4 participants
@mmusich @cmsbuild @antoniovilela @tjavaid